On Wed, Jun 29, 2022 at 06:15:49PM +0200, Jason A. Donenfeld wrote:
On Wed, Jun 29, 2022 at 5:28 PM Greg KH gregkh@linuxfoundation.org wrote:
On Wed, Jun 29, 2022 at 01:42:40PM +0200, Jason A. Donenfeld wrote:
--- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4284,6 +4284,7 @@ int wake_up_state(struct task_struct *p, unsigned int state) { return try_to_wake_up(p, state, 0); } +EXPORT_SYMBOL(wake_up_state);
Should be EXPORT_SYMBOL_GPL(), right?
The highly similar wake_up_process() above it, which has the exact same body, except the `state` argument is fixed as TASK_NORMAL, is an EXPORT_SYMBOL(). So I figured this one should follow form. Let me know if that's silly, and I'll send a v+1 changing it to _GPL though.
I'll let the maintainers of this code decide that, I wasn't aware of the other symbol above this. It's their call, as it's their code.
thanks,
greg k-h