Re: [PATCH] tpm: Switch to platform_get_irq_optional()

On Wed, Oct 23, 2019 at 02:32:48PM +0300, Jarkko Sakkinen wrote:

On Mon, Oct 21, 2019 at 11:05:02AM -0300, Jason Gunthorpe wrote:

...

On Sat, Oct 19, 2019 at 11:45:28AM +0200, Hans de Goede wrote:

...

Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()"), platform_get_irq() will call dev_err() on an error, as the IRQ usage in the tpm_tis driver is optional, this is undesirable.

This should have a fixes line for the above, or maybe the commit that addtion the _optional version..

Is this fixing something?

Yes, an earlier commit caused new bogus warnings to appear, this is fixing that regression

Jason