On Tue, Mar 26, 2019 at 08:58:28AM -0700, Tadeusz Struk wrote:
Hi Jarkko, On 3/25/19 7:09 AM, Jarkko Sakkinen wrote:
It is still missing the comment I asked to add. Otherwise, it is good.
Sorry, I didn't see your email with the suggestion earlier. To be honest I'm not sure if this comment adds much value, or if it is even correct. The poll doesn't "succeed" or "fail". It just returns a mask indicating if there is any data to read or if the user can write.
Isn't the commit message + 'git blame' enough to remember why it was done this way?
Comments in the code have also their time and place especially when doing code reviews. Usually I like to have something in a site where there has been a race even if it was for fairly trivial reason. If you want to refine the comment to be more to the point, that is perfectly fine.
/Jarkko