From: Zijun Hu quic_zijuhu@quicinc.com
In of_resolve_phandles(), refcount of device node @local_fixups will be increased if the for_each_child_of_node() exits early, but nowhere to decrease the refcount, so cause refcount leakage for the node.
Fix by adding of_node_put(@local_fixups) before return.
Fixes: da56d04c806a ("of/resolver: Switch to new local fixups format.") Cc: stable@vger.kernel.org Signed-off-by: Zijun Hu quic_zijuhu@quicinc.com --- drivers/of/resolver.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 779db058c42f5b8198ee3417dfaab80c81b43e4c..b589e59667fd3ea2c2bd5240414803cb17707ec9 100644 --- a/drivers/of/resolver.c +++ b/drivers/of/resolver.c @@ -256,6 +256,7 @@ int of_resolve_phandles(struct device_node *overlay) phandle phandle, phandle_delta; int err;
+ local_fixups = NULL; tree_symbols = NULL;
if (!overlay) { @@ -332,6 +333,7 @@ int of_resolve_phandles(struct device_node *overlay) if (err) pr_err("overlay phandle fixup failed: %d\n", err); of_node_put(tree_symbols); + of_node_put(local_fixups);
return err; }