Hi Sasha,
On Mon, Jan 28, 2019 at 10:41:05AM -0500, Sasha Levin wrote:
From: Uwe Kleine-König uwe@kleine-koenig.org
[ Upstream commit 0832e93632c61987d504e251b927a2be769dd21a ]
When a driver fails to bind because a resource it still missing it's not helpful to report this as (usually) probing is repeated later.
I do not think that patch that merely suppresses a harmless warning in dmesg belongs in stable.
Signed-off-by: Uwe Kleine-König uwe@kleine-koenig.org Signed-off-by: Dmitry Torokhov dmitry.torokhov@gmail.com Signed-off-by: Sasha Levin sashal@kernel.org
drivers/input/misc/rotary_encoder.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/input/misc/rotary_encoder.c b/drivers/input/misc/rotary_encoder.c index 30ec77ad32c6..d748897bf5e9 100644 --- a/drivers/input/misc/rotary_encoder.c +++ b/drivers/input/misc/rotary_encoder.c @@ -240,8 +240,10 @@ static int rotary_encoder_probe(struct platform_device *pdev) encoder->gpios = devm_gpiod_get_array(dev, NULL, GPIOD_IN); if (IS_ERR(encoder->gpios)) {
dev_err(dev, "unable to get gpios\n");
return PTR_ERR(encoder->gpios);
err = PTR_ERR(encoder->gpios);
if (err != -EPROBE_DEFER)
dev_err(dev, "unable to get gpios: %d\n", err);
} if (encoder->gpios->ndescs < 2) { dev_err(dev, "not enough gpios found\n");return err;
-- 2.19.1
Thanks.