On Mon, Feb 10, 2025 at 09:28:01PM +0100, Jesper Nilsson wrote:
From: Max Kellermann max.kellermann@ionos.com
This reverts commit 484fd6c1de13b336806a967908a927cc0356e312. The commit caused a regression because now the umask was applied to symlinks and the fix is unnecessary because the umask/O_TMPFILE bug has been fixed somewhere else already.
Fixes: https://lore.kernel.org/lkml/28DSITL9912E1.2LSZUVTGTO52Q@mforney.org/ Signed-off-by: Max Kellermann max.kellermann@ionos.com Reviewed-by: Christian Brauner brauner@kernel.org Tested-by: Michael Forney mforney@mforney.org Link: https://lore.kernel.org/r/20240315142956.2420360-1-max.kellermann@ionos.com Signed-off-by: Theodore Ts'o tytso@mit.edu (cherry picked from commit c77194965dd0dcc26f9c1671d2e74e4eb1248af5)
This revert never reached linux-5.15.y, and caused the same regression with symbolic links. The original problem is just as the revert states fixed and the test program for O_TMPFILE works as expected.
This revert never hit any of the other stable kernels either, should it go to all of them?
Also, you didn't sign off on this :(
thanks,
greg k-h