Re: [PATCH] blk-mq: Fix recently introduced races in the timeout handling code

Hello,

On Mon, Apr 09, 2018 at 05:03:05PM +0000, Bart Van Assche wrote:

My opinion is not only that the two patches that you posted recently do not fix all the races that are fixed by this patch but also that the races that

The race was with the path where the ownership of a timed out request is passed back to normal completion path and those two patches fix that, right?

exist today in the blk-mq timeout handling code cannot be fixed completely using RCU only.

I really don't think that is that complicated. Let's first confirm the race fix and get to narrowing / closing that window.

That race window did not exist in the legacy block layer. I don't think

IIRC, it did. It was there when I first started working on libata EH years ago.

Thanks.