On Thu, Feb 23, 2023 at 9:31 AM Guenter Roeck linux@roeck-us.net wrote:
This isn't the first time this happens. I seem to recall that you mentioned some time ago that whatever you use to apply patches (quilt ?) doesn't handle executable permission bits correctly.
Note that even though git itself does handle these things right, we've also always said that if some old fogey wants to use tar-balls and patches, that's supposed to still work.
I guess the same "old fogey" comment then covers quilt too.
End result: we should try to generally not execute our scripts directly, but to explicitly state which interpreter it should use, rather than then depend on the #! in the script itself to do it.
In fact, for shell scripting in particular, we go further than that, and use $(CONFIG_SHELL)
Of course, in this case, it's actually using the Makefile '$(shell ..)' format, so I guess it looks a bit odd to write it as
$(shell $(CONFIG_SHELL) script..)
but I do think we should do it.
Now, independently of that I also think quilt should probably just learn the git world order about file modes, because let's face it, git _has_ taken over the world. Mwhahahhahahaahaaa!
Linus