15 Jun
2020
15 Jun
'20
9:30 a.m.
On Mon, Jun 15, 2020 at 12:26:37PM +0300, Vladimir Oltean wrote:
Let's rephrase it: you think therefore that completion should be
initialzed *after* requesting shared interrupts? You think that exactly that order shall be used in the source code?
Best regards, Krzysztof
I think that completion should be initialized before it is used, just like any other variable. So far you have not proven any code path through which it can be used uninitialized, therefore I don't see why this should be accepted as a bug fix. Cleanup, cosmetic refactoring, design patterns, whatever, sure.
Sure, let it call then cleanup, cosmetic refactoring.
Best regards, Krzysztof