Hi Dean,
Could you test the patch?
-----Original Message----- From: Kailang Sent: Friday, November 8, 2024 10:59 AM To: 'Dean Matthew Menezes' dean.menezes@utexas.edu; Takashi Iwai tiwai@suse.de Cc: stable@vger.kernel.org; regressions@lists.linux.dev; Jaroslav Kysela perex@perex.cz; Takashi Iwai tiwai@suse.com; Linux Sound System linux-sound@vger.kernel.org; Greg KH gregkh@linuxfoundation.org Subject: RE: No sound on speakers X1 Carbon Gen 12
Hi Dean,
I check issues with our site machine. I guess your BIOS didn't update to newer version.
If BIOS no update, you need to add below patch.
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 74ca0bb6c091..126b68140e7e 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7450,7 +7450,6 @@ static void alc287_alc1318_playback_pcm_hook(struct hda_pcm_stream *hinfo, struct snd_pcm_substream *substream, int action) {
- alc_write_coef_idx(codec, 0x10, 0x8806); /* Change MLK to GPIO3 */ switch (action) { case HDA_GEN_PCM_ACT_OPEN: alc_write_coefex_idx(codec, 0x5a, 0x00, 0x954f); /* write gpio3 to
high */ @@ -7464,7 +7463,6 @@ static void alc287_alc1318_playback_pcm_hook(struct hda_pcm_stream *hinfo, static void alc287_s4_power_gpio3_default(struct hda_codec *codec) { if (is_s4_suspend(codec)) {
alc_write_coef_idx(codec, 0x10, 0x8806); /* Change MLK to GPIO3*/ alc_write_coefex_idx(codec, 0x5a, 0x00, 0x554f); /* write gpio3 as default value */ } } @@ -7473,9 +7471,17 @@ static void alc287_fixup_lenovo_thinkpad_with_alc1318(struct hda_codec *codec, const struct hda_fixup *fix, int action) { struct alc_spec *spec = codec->spec;
static const struct coef_fw coefs[] = {WRITE_COEF(0x24, 0x0013), WRITE_COEF(0x25, 0x0000),WRITE_COEF(0x26, 0xC300),
WRITE_COEF(0x28, 0x0001), WRITE_COEF(0x29, 0xb023),WRITE_COEF(0x24, 0x0013), WRITE_COEF(0x25, 0x0000),WRITE_COEF(0x26, 0xC301),
WRITE_COEF(0x28, 0x0001), WRITE_COEF(0x29, 0xb023),};if (action != HDA_FIXUP_ACT_PRE_PROBE) return;
alc_update_coef_idx(codec, 0x10, 1<<11, 1<<11);alc_process_coef_fw(codec, coefs);spec->power_hook = alc287_s4_power_gpio3_default; spec->gen.pcm_playback_hook =
alc287_alc1318_playback_pcm_hook; }
-----Original Message----- From: Dean Matthew Menezes dean.menezes@utexas.edu Sent: Saturday, October 26, 2024 8:23 AM To: Takashi Iwai tiwai@suse.de Cc: Kailang kailang@realtek.com; stable@vger.kernel.org; regressions@lists.linux.dev; Jaroslav Kysela perex@perex.cz; Takashi Iwai tiwai@suse.com; Linux Sound System linux-sound@vger.kernel.org; Greg KH gregkh@linuxfoundation.org Subject: Re: No sound on speakers X1 Carbon Gen 12
External mail.
I get the same output: axiom /home/dean # hda-verb /dev/snd/hwC0D0 0x5a SET_COEF_INDEX 0x00 nid = 0x5a, verb = 0x500, param = 0x0 value = 0x0 axiom /home/dean # hda-verb /dev/snd/hwC0D0 0x5a GET_PROC_COEF 0x00 nid = 0x5a, verb = 0xc00, param = 0x0 value = 0x0
On Fri, 25 Oct 2024 at 02:16, Takashi Iwai tiwai@suse.de wrote:
On Fri, 25 Oct 2024 03:22:38 +0200, Dean Matthew Menezes wrote:
I get the same values for both
axiom /home/dean/linux-6.11.3/sound/pci/hda # hda-verb /dev/snd/hwC0D0 0x5a SET_COEF_INDEX 0x00 nid = 0x5a, verb = 0x500, param = 0x0 value = 0x0
Here OK, but...
axiom /home/dean/linux-6.11.3/sound/pci/hda # hda-verb /dev/snd/hwC0D0 0x5a SET_PROC_COEF 0x00
... here run GET_PROC_COEF instead, i.e. to read the value.
thanks,
Takashi