On 10/08/25 at 16:22, Thorsten Blum wrote:
Use 'min(len, x)' as the index instead of just 'len' to NUL-terminate the copied 'line' string at the correct position.
Add a newline after the local variable declarations to silence a checkpatch warning.
Cc: stable@vger.kernel.org Fixes: 692d97c380c6 ("kconfig: new configuration interface (nconfig)") Signed-off-by: Thorsten Blum thorsten.blum@linux.dev
scripts/kconfig/nconf.gui.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/scripts/kconfig/nconf.gui.c b/scripts/kconfig/nconf.gui.c index 7206437e784a..ec021ebd2c52 100644 --- a/scripts/kconfig/nconf.gui.c +++ b/scripts/kconfig/nconf.gui.c @@ -175,8 +175,9 @@ void fill_window(WINDOW *win, const char *text) for (i = 0; i < total_lines; i++) { char tmp[x+10]; const char *line = get_line(text, i);
int len = get_line_length(line);strncpy(tmp, line, min(len, x));
int len = min(get_line_length(line), x);strncpy(tmp, line, len);
Is there a rationale behind the choice to avoid to use snprintf() in these circumstance? Preferring snprintf() you will not have to take care to compute the position of the NULL terminating character of the string, it's done automatically by this function.
Best regards,