Re: [Linux-stable-mirror] [PATCH] bcache: Fix building error on MIPS

Am Thu, 16 Nov 2017 11:06:13 +0800 schrieb Huacai Chen chenhc@lemote.com:

diff --git a/include/uapi/linux/bcache.h b/include/uapi/linux/bcache.h index 90fc490..5cc599c 100644 --- a/include/uapi/linux/bcache.h +++ b/include/uapi/linux/bcache.h @@ -91,7 +91,7 @@ PTR_FIELD(PTR_GEN, 0, 8) #define PTR_CHECK_DEV ((1 << PTR_DEV_BITS) -

-#define PTR(gen, offset, dev) \ +#define MAKE_PTR(gen, offset, dev) \ ((((__u64) dev) << 51) | ((__u64) offset) << 8 | gen) /* Bkey utility code */

I don't think you make it any better by calling it MAKE_PTR then. How's the next guy stumbling across such a conflict calling his definition then? CREATE_PTR?

Why not call it BCH_PTR or similar?