23 Jan
2020
23 Jan
'20
11:35 a.m.
On 23/01/20 12:32, Vitaly Kuznetsov wrote:
Likely a personal preference but the suggested naming is a bit confusing: we use 'base_cycles' to keep 'xtime_nsec' and 'offset' to keep ... 'base'. Not that I think that 'struct timekeeper' is perfect but at least it is documented. Should we maybe just stick to it (and name 'struct pvclock_clock' fields accordingly?)
The problem is that xtime_nsec is not nanoseconds, and I'd really not want to have a worse name just for consistency. :( I chose "base_cycles" as an incremental improvement over nsec_base, even though that meant also changing struct timekeeper's "base" to "offset".
Paolo