On 21/03/2023 14:14, Johan Hovold wrote:
On Thu, Mar 09, 2023 at 10:41:18PM +0100, Martin Blumenstingl wrote:
On Mon, Mar 6, 2023 at 11:35 AM Johan Hovold johan+linaro@kernel.org wrote: [...]
@@ -325,23 +325,23 @@ static int meson_drv_bind_master(struct device *dev, bool has_components)
ret = meson_encoder_hdmi_init(priv);I'm wondering if component_bind_all() can be moved further down. Right now it's between meson_encoder_cvbs_init() and meson_encoder_hdmi_init(). So it seems that encoders don't rely on component registration.
Perhaps it can, but that would be a separate change (unless there is something inherently wrong with the current initialisation order).
The CVBS doesn't rely on any components unlike HDMI, this explains the current position of component_bind_all().
Unfortunately I am also not familiar with this and I'm hoping that Neil can comment on this.
Any comments on this one, Neil?
Yep, components should be bind for HDMI encoder/bridge init.
Anyway for this patch, sorry for the delay, but it's looks fine:
Acked-by: Neil Armstrong neil.armstrong@linaro.org
Johan