18 Dec
2024
18 Dec
'24
8 a.m.
Once device_add(&dev->dev) failed, call put_device() to explicitly release dev->dev. Or it could cause double free problem.
https://elixir.bootlin.com/linux/v6.13-rc3/source/drivers/base/core.c#L3521
…
Found by code review.
https://elixir.bootlin.com/linux/v6.13-rc3/source/drivers/virtio/virtio.c#L4...
Will possibilities become interesting to improve automated source code analyses accordingly?
…
+++ b/drivers/virtio/virtio.c @@ -503,6 +503,7 @@ int register_virtio_device(struct virtio_device *dev)
out_of_node_put: of_node_put(dev->dev.of_node);
- put_device(&dev->dev);
out_ida_remove: ida_free(&virtio_index_ida, dev->index); out:
How much can the ordering matter for such resource cleanup calls here?
Regards, Markus