On Tue, Jun 06, 2023 at 12:12:51PM +0300, Paul Fertser wrote:
Hi Simon,
On Tue, Jun 06, 2023 at 11:03:31AM +0200, Simon Horman wrote:
On Mon, Jun 05, 2023 at 10:34:07AM +0300, Paul Fertser wrote:
On DBDC devices the first (internal) phy is only capable of using 2.4 GHz band, and the 5 GHz band is exposed via a separate phy object, so avoid the false advertising.
Can I clarify that the second object won't hit the logic change below and thus be limited to 2GHz?
The second object (external 5 GHz phy) doesn't have an EEPROM of its own, and is created explicitly with just this band enabled:
https://elixir.bootlin.com/linux/latest/source/drivers/net/wireless/mediatek... https://elixir.bootlin.com/linux/latest/source/drivers/net/wireless/mediatek...
So it won't hit the logic change and it will be limited to 5 GHz.
Thanks Paul,
in that case this patch looks good to me.
Reviewed-by: Simon Horman simon.horman@corigine.com