On Wed, Nov 29, 2017 at 11:43:24AM -0700, Jason Gunthorpe wrote:
On Wed, Nov 29, 2017 at 07:59:49AM -0500, Mike Marciniszyn wrote:
From: Don Hiatt don.hiatt@intel.com
Upstream commit 4988be5813ff2afdc0d8bfa315ef34a577d3efbf.
On OPA devices opa_local_smp_check will receive 32Bit LIDs when the LID is Extended. In such cases, it is okay to lose the upper 16 bits of the LID as this information is obtained elsewhere. Do not issue a warning when calling ib_lid_cpu16() in this case by masking out the upper 16Bits.
The concept for the 32 bit lids was to keep it 32 bit inside the kernel, ingress_key_table_fail puts the lid into err_info_constraint.slid which is already 32 bits, so this cannot be the right place for this.
These truncations should only appear at the uapi boundary.
Ok, but that's what the change in Linus's tree does. If you object to that, please fix it there :)
thanks,
greg k-h