On Thu, Aug 15, 2024 at 10:07:09PM -0700, Andrew Morton wrote:
On Fri, 9 Aug 2024 11:41:42 +0200 Uladzislau Rezki urezki@gmail.com wrote:
Acked-by: Barry Song baohua@kernel.org
because we already have a fallback here:
void *__vmalloc_node_range_noprof :
fail: if (shift > PAGE_SHIFT) { shift = PAGE_SHIFT; align = real_align; size = real_size; goto again; }
This really deserves a comment because this is not really clear at all. The code is also fragile and it would benefit from some re-org.
Thanks for the fix.
Acked-by: Michal Hocko mhocko@suse.com
I agree. This is only clear for people who know the code. A "fallback" to order-0 should be commented.
It's been a week. Could someone please propose a fixup patch to add this comment?
I will send the patch. This is week i have a vacation, thus i am a bit slow.
-- Uladzislau Rezki