Hi,
On Tue, Mar 19, 2024 at 8:30 AM Johan Hovold johan+linaro@kernel.org wrote:
The WCN6855 firmware on the Lenovo ThinkPad X13s expects the Bluetooth device address in big-endian order when setting it using the EDL_WRITE_BD_ADDR_OPCODE command.
Presumably, this is the case for all non-ROME devices which all use the EDL_WRITE_BD_ADDR_OPCODE command for this (unlike the ROME devices which use a different command and expect the address in little-endian order).
Reverse the little-endian address before setting it to make sure that the address can be configured using tools like btmgmt or using the 'local-bd-address' devicetree property.
Note that this can potentially break systems with boot firmware which has started relying on the broken behaviour and is incorrectly passing the address via devicetree in big-endian order.
Fixes: 5c0a1001c8be ("Bluetooth: hci_qca: Add helper to set device address") Cc: stable@vger.kernel.org # 5.1 Cc: Balakrishna Godavarthi quic_bgodavar@quicinc.com Cc: Matthias Kaehlcke mka@chromium.org Tested-by: Nikita Travkin nikita@trvn.ru # sc7180 Signed-off-by: Johan Hovold johan+linaro@kernel.org
drivers/bluetooth/btqca.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
Personally, I'd prefer it if you didn't break bisectability with your series. As it is, if someone applies just the first 3 patches they'll end up with broken Bluetooth.
IMO the order should be: 1. Binding (currently patch #1) 2. Trogdor dt patch, which won't hurt on its own (currently patch #5) 3. Bluetooth subsystem patch handling the quirk (currently patch #2) 4. Qualcomm change to fix the endianness and handle the quirk squashed into 1 patch (currently patch #3 + #4)
...and the patch that changes the Qualcomm driver should make it obvious that it depends on the trogdor DT patch in the change description.
With patches #3 and #4 combined, feel free to add my Reviewed-by tag as both patches look fine to me.
-Doug