On Wed, Nov 27, 2024 at 11:20:05AM -0500, Sasha Levin wrote:
On Tue, Nov 26, 2024 at 03:21:22PM +0800, Shung-Hsi Yu wrote:
Currently the BPF selftests in fails to compile (with tools/testing/selftests/bpf/vmtest.sh) due to use of test helpers that were not backported, namely:
What was the offending backport? It might make more sense to just revert that.
- for __xlated() it is commit 68ec5395bc24, backport of mainline commit a41b3828ec05 ("selftests/bpf: Verify that sync_linked_regs preserves subreg_def") - for netlink_helper-related error " netlink_helpers.h: No such file or directory", is should be commit e41db26543ef backport of mainline commit 5f1d18de7918 ("selftests/bpf: Extend tcx tests to cover late tcx_entry release")
For __xlated() I think we just need a refresh patch that removes its use, the test cases should function without it albeit at a reduced coverage.
OTOH for netlink_helper it's probably simpler to have it backported (note: there was the precedence of b02372814ad6, but that's related to netkit, which was not in 6.6, where as tcx is in 6.6).
I'll send a new series which the proposed changes.
Shung-Hsi