-----Original Message----- From: Intel-wired-lan intel-wired-lan-bounces@osuosl.org On Behalf Of Olivier Matz Sent: Wednesday, April 6, 2022 11:53 AM To: netdev@vger.kernel.org Cc: Paul Menzel pmenzel@molgen.mpg.de; intel-wired-lan@osuosl.org; stable@vger.kernel.org; Jakub Kicinski kuba@kernel.org; Nicolas Dichtel nicolas.dichtel@6wind.com; Paolo Abeni pabeni@redhat.com; David S . Miller davem@davemloft.net Subject: [Intel-wired-lan] [PATCH net v2 1/2] ixgbe: fix bcast packets Rx on VF after promisc removal
After a VF requested to remove the promiscuous flag on an interface, the broadcast packets are not received anymore. This breaks some protocols like ARP.
In ixgbe_update_vf_xcast_mode(), we should keep the IXGBE_VMOLR_BAM bit (Broadcast Accept) on promiscuous removal.
This flag is already set by default in ixgbe_set_vmolr() on VF reset.
Fixes: 8443c1a4b192 ("ixgbe, ixgbevf: Add new mbox API xcast mode") Cc: stable@vger.kernel.org Cc: Nicolas Dichtel nicolas.dichtel@6wind.com Signed-off-by: Olivier Matz olivier.matz@6wind.com
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c index 7f11c0a8e7a9..8d108a78941b 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c @@ -1184,9 +1184,9 @@ static int ixgbe_update_vf_xcast_mode(struct
Tested-by: Konrad Jankowski konrad0.jankowski@intel.com