3.16.65-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Ben Hutchings ben@decadent.org.uk
Revert commit 36a0db05310fbee38b59fed7e1306c1a095f8c8f, a minimal backport of commit cabfb3680f78981d26c078a26e5c748531257ebb upstream. We need a complete backport to avoid a regression for SMB3 authenticated mounts.
Reported-by: Stephan Seitz stse+debian@fsing.rootsland.net References: https://lists.debian.org/debian-lts/2019/03/msg00071.html Cc: Dan Aloni dan@kernelim.com Signed-off-by: Ben Hutchings ben@decadent.org.uk --- --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -608,7 +608,6 @@ SMB2_sess_setup(const unsigned int xid, */ kfree(ses->auth_key.response); ses->auth_key.response = NULL; - ses->auth_key.len = 0;
/* * If memory allocation is successful, caller of this function @@ -769,7 +768,6 @@ ssetup_exit: rc = server->ops->generate_signingkey(ses); kfree(ses->auth_key.response); ses->auth_key.response = NULL; - ses->auth_key.len = 0; if (rc) { cifs_dbg(FYI, "SMB3 session key generation failed\n"); @@ -794,7 +792,6 @@ keygen_exit: if (!server->sign) { kfree(ses->auth_key.response); ses->auth_key.response = NULL; - ses->auth_key.len = 0; } kfree(ses->ntlmssp);