Re: [PATCH V2] serial: tegra: Only print FIFO error message when an error occurs

On Wed, Jun 30, 2021 at 01:56:43PM +0100, Jon Hunter wrote:

The Tegra serial driver always prints an error message when enabling the FIFO for devices that have support for checking the FIFO enable status. Fix this by displaying the error message, only when an error occurs.

Finally, update the error message to make it clear that enabling the FIFO failed and display the error code.

Fixes: 222dcdff3405 ("serial: tegra: check for FIFO mode enabled status") Cc: stable@vger.kernel.org Signed-off-by: Jon Hunter jonathanh@nvidia.com

---

Changes since V1:

• Updated the error message to make it more meaningful.

drivers/tty/serial/serial-tegra.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)

Looks good:

Acked-by: Thierry Reding treding@nvidia.com