Re: [PATCH v4] blk-mq: Fix race conditions in request timeout handling

Hello,

On Tue, Apr 10, 2018 at 11:38:18PM +0800, Ming Lei wrote:

I agree, the issue should be in driver's irq handler and .timeout in theory.

For example, even though one request has been done by irq handler, .timeout still may return RESET_TIMER.

blk-mq can use a separate flag to track normal completions during timeout and complete the request normally on RESET_TIMER if the flag is set while EH was in progress. With a bit of care, we'd be able to plug the race completely.

Thanks.