On Wed, Jul 11, 2018 at 04:52:10PM +0300, Serge Semin wrote:
Hello Christoph,
On Tue, Jul 10, 2018 at 11:56:31PM -0700, Christoph Hellwig hch@infradead.org wrote:
- This is a MIPS specific ioremap variant. ioremap_cacheable_cow
*/
- requests a cachable mapping with CWB attribute enabled.
#define ioremap_cacheable_cow(offset, size) \ __ioremap_mode((offset), (size), _CACHE_CACHABLE_COW)
This isn't actually used anywhere in the kernel tree. Please remove it as well.
I don't really know whether it is necessary at this point. We discarded the ioremap_uncached_accelerated() method, since the obvious alternative is now available: ioremap_wc(). While ioremap_cacheable_cow() hasn't got one. So if it was up to me, I'd leave it here. Anyway if the subsystem maintainers think otherwise, I won't refuse to submit a patch with this method removal.
The function is entirely unused in the kernel tree, please remove it.