On Tue, Apr 17, 2018 at 10:18:17AM -0500, Bryant G. Ly wrote:
On 4/13/18 11:44 AM, Christoph Hellwig wrote:
The patch looks fine, but in general I think descriptions of what you fixed in the code or more important than starting out with a backtrace.
E.g. please explain what was wrong, how you fixed it and only after that mention how it was caught. (preferably without the whole trace)
I will put the trace at the end next time. Do you want me to re-submit with it moved?
Please do.