Re: [PATCH] sfc: Add error handling for devlink_info_serial_number_put()

On Tue, 1 Apr 2025 21:05:57 +0800 Wentao Liang wrote:

if (!rc) { snprintf(sn, EFX_MAX_SERIALNUM_LEN, "%pm", mac_address);

• devlink_info_serial_number_put(req, sn);
  

• err = devlink_info_serial_number_put(req, sn);
  

• if (err)
  

• 	return err;
  

Why are you introducing another variable? You can do this:

if (rc) return rc; snprintf... return devlink_info..