-----Original Message----- From: Simon Horman horms@kernel.org Sent: Tuesday, August 1, 2023 9:01 PM To: Souradeep Chakrabarti schakrabarti@linux.microsoft.com Cc: KY Srinivasan kys@microsoft.com; Haiyang Zhang haiyangz@microsoft.com; wei.liu@kernel.org; Dexuan Cui decui@microsoft.com; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; Long Li longli@microsoft.com; Ajay Sharma sharmaajay@microsoft.com; leon@kernel.org; cai.huoqing@linux.dev; ssengar@linux.microsoft.com; vkuznets vkuznets@redhat.com; tglx@linutronix.de; linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; linux- rdma@vger.kernel.org; Souradeep Chakrabarti schakrabarti@microsoft.com; stable@vger.kernel.org Subject: [EXTERNAL] Re: [PATCH V7 net] net: mana: Fix MANA VF unload when hardware is
On Tue, Aug 01, 2023 at 05:29:13AM -0700, Souradeep Chakrabarti wrote:
...
Hi Souradeep,
- for (i = 0; i < apc->num_queues; i++) {
txq = &apc->tx_qp[i].txq;while (skb = skb_dequeue(&txq->pending_skbs)) {W=1 builds with both clang-16 and gcc-12 complain that they would like an extra set of parentheses around an assignment used as a truth value.
Thanks for letting me know. I will fix it in next version.
mana_unmap_skb(skb, apc);dev_consume_skb_any(skb);}atomic_set(&txq->pending_sends, 0);- } /* We're 100% sure the queues can no longer be woken up, because
*/
- we're sure now mana_poll_tx_cq() can't be running.
-- 2.34.1