Hi Dan,
I love your patch! Yet something to improve:
[auto build test ERROR on bba413deb1065f1291cb1f366247513f11215520]
url: https://github.com/0day-ci/linux/commits/Dan-Williams/Renovate-memcpy_mcsafe... base: bba413deb1065f1291cb1f366247513f11215520 config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386
If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot lkp@intel.com
All errors (new ones prefixed by >>, old ones prefixed by <<):
arch/x86/kernel/quirks.c: In function 'quirk_intel_brickland_xeon_ras_cap':
arch/x86/kernel/quirks.c:635:3: error: implicit declaration of function 'enable_copy_mc_fragile' [-Werror=implicit-function-declaration]
enable_copy_mc_fragile(); ^~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- arch/x86/kernel/cpu/mce/core.c: In function 'mcheck_late_init':
arch/x86/kernel/cpu/mce/core.c:2595:3: error: implicit declaration of function 'enable_copy_mc_fragile'; did you mean 'enable_p5_mce'? [-Werror=implicit-function-declaration]
enable_copy_mc_fragile(); ^~~~~~~~~~~~~~~~~~~~~~ enable_p5_mce cc1: some warnings being treated as errors
vim +/enable_copy_mc_fragile +635 arch/x86/kernel/quirks.c
623 624 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_16H_NB_F3, 625 amd_disable_seq_and_redirect_scrub); 626 627 /* Ivy Bridge, Haswell, Broadwell */ 628 static void quirk_intel_brickland_xeon_ras_cap(struct pci_dev *pdev) 629 { 630 u32 capid0; 631 632 pci_read_config_dword(pdev, 0x84, &capid0); 633 634 if (capid0 & 0x10)
635 enable_copy_mc_fragile();
636 } 637
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org