Re: [PATCH] qlcnic: fix a memory leak in qlcnic_sriov_set_guest_vlan_mode()

On 2/28/25 10:24 AM, Haoxiang Li wrote:

Add qlcnic_sriov_free_vlans() to free the memory allocated by qlcnic_sriov_alloc_vlans() if "sriov->allowed_vlans" fails to be allocated.

Fixes: 91b7282b613d ("qlcnic: Support VLAN id config.") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li haoxiang_li2024@163.com

AFAICS the fix is not complete: sriov vlans could still be leaked when qlcnic_sriov_alloc_vlans() fails on any VF with id > 0.

Please handle even such scenario.

Thanks!

Paolo