Re: [PATCH] i2c: qup: Add error handling in qup_i2c_xfer_v2()

Hi Mukesh,

...

...

@@ -1588,7 +1588,9 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap, ret = qup_i2c_bus_active(qup, ONE_BYTE); if (!ret)

• qup_i2c_change_state(qup, QUP_RESET_STATE);
  

• err = qup_i2c_change_state(qup, QUP_RESET_STATE);
  

• if (err)

• return err;
  

Is there an error seen around this ? Expecting this to work as is. After an error, what next ? Just return back to framework ?

thanks for chiming in. qup_i2c_change_state() can fail, why shouldn't we consider the possibility to fail?

Thanks, Andi