On Tue, 2021-10-12 at 23:32 +0200, Halil Pasic wrote:
On Tue, 12 Oct 2021 15:36:36 +0200 Vineeth Vijayan vneethv@linux.ibm.com wrote:
Looks good. Thanks. Acked-by: Vineeth Vijayan vneethv@linux.ibm.com
Can I convince you to upgrade to Reviewed-by?
You got it.
Reviewed-by: Vineeth Vijayan vneethv@linux.ibm.com
Some minor questions below.
On Mon, 2021-10-11 at 13:59 +0200, Halil Pasic wrote:
Since commit 48720ba56891 ("virtio/s390: use DMA memory for ccw I/O and classic notifiers") we were supposed to make sure that virtio_ccw_release_dev() completes before the ccw device and the attached dma pool are torn down, but unfortunately we did not. Before that commit it used to be OK to delay cleaning up the memory allocated by virtio-ccw indefinitely (which isn't really intuitive for guys used to destruction happens in reverse construction order), but now we trigger a BUG_ON if the genpool is destroyed before all memory allocated form it.
allocated from it ?
Yes. And I think I should add "is deallocated." to the end as well, because we don't destroy memory, we deallocate it ;)