From: Eric Dumazet edumazet@google.com
commit 166ee5b87866de07a3e56c1b757f2b5cabba72a5 upstream.
Should qdisc_alloc() fail, we must release the module refcount we got right before.
Fixes: 6da7c8fcbcbd ("qdisc: allow setting default queuing discipline") Signed-off-by: Eric Dumazet edumazet@google.com Acked-by: John Fastabend john.r.fastabend@intel.com Acked-by: John Fastabend john.r.fastabend@intel.com Signed-off-by: David S. Miller davem@davemloft.net Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
--- net/sched/sch_generic.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
--- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c @@ -626,18 +626,19 @@ struct Qdisc *qdisc_create_dflt(struct n struct Qdisc *sch;
if (!try_module_get(ops->owner)) - goto errout; + return NULL;
sch = qdisc_alloc(dev_queue, ops); - if (IS_ERR(sch)) - goto errout; + if (IS_ERR(sch)) { + module_put(ops->owner); + return NULL; + } sch->parent = parentid;
if (!ops->init || ops->init(sch, NULL) == 0) return sch;
qdisc_destroy(sch); -errout: return NULL; } EXPORT_SYMBOL(qdisc_create_dflt);