On Thu, Jun 13, 2024 at 03:02:43PM +0200, Miklos Szeredi wrote:
On Thu, Jun 13, 2024 at 2:00 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
5.4-stable review patch. If anyone has any objections, please let me know.
From: Miklos Szeredi mszeredi@redhat.com
[ Upstream commit 096802748ea1dea8b476938e0a8dc16f4bd2f1ad ]
This is already done by vfs_prepare_mode() when creating the upper object by vfs_create(), vfs_mkdir() and vfs_mknod().
No regressions have been observed in xfstests run with posix acls turned off for the upper filesystem.
Fixes: 1639a49ccdce ("fs: move S_ISGID stripping into the vfs_*() helpers")
Hi Greg,
This patch is in fact a cleanup, not a fix (maybe I shouldn't have used the Fixes: tag).
Considering that the "fixed" commit is from v6.0, I think backporting to anything earlier than v6.0 is not a good idea.
Thanks for letting me know, I'll go drop it from all queues now.
greg k-h