On Wed, Mar 10, 2021 at 11:49:38AM +0100, Hans Verkuil wrote:
From: Jernej Skrabec jernej.skrabec@siol.net
[ Upstream commit 7072db89572135f28cad65f15877bf7e67cf2ff8 ]
According to v4l2 request api specifications, it's allowed to skip control if its content isn't changed for performance reasons. Cedrus driver predates that, so it has implemented mechanism to check if all required controls are included in one request.
Conform to specifications with removing that mechanism.
Note that this mechanism with static required flag isn't very good anyway because need for control is usually signaled in other controls.
Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver") Cc: stable@vger.kernel.org Signed-off-by: Jernej Skrabec jernej.skrabec@siol.net Signed-off-by: Hans Verkuil hverkuil-cisco@xs4all.nl
Without this patch the H264 cedrus support is non-compliant, and since 5.11 was the first kernel with a stable H264 stateless codec ABI it would be good to have this merged for 5.11 so the cedrus driver can be used with H264.
Now queued up, thanks.
greg k-h