Re: [PATCH v4] blk-mq: Fix race conditions in request timeout handling

On 04/10/18 14:54, tj@kernel.org wrote:

On Tue, Apr 10, 2018 at 09:46:23PM +0000, Bart Van Assche wrote:

...

On Tue, 2018-04-10 at 14:33 -0700, tj@kernel.org wrote:

...

•   else
  

•           rq->missed_completion = true;
  

In this patch I found code that sets rq->missed_completion but no code that clears it. Did I perhaps miss something?

Ah, yeah, I was moving it out of add_timer but forgot to actully add it to the issue path. Fixed patch below.

BTW, no matter what we do w/ the request handover between normal and timeout paths, we'd need something similar. Otherwise, while we can reduce the window, we can't get rid of it.

[ ... ]

Hello Tejun,

This patch no longer applies cleanly on Jens' tree. Can you rebase and repost it?

Thanks,

Bart.