Hi Sean,
On Thu, Feb 15, 2024 at 11:23:26AM -0500, Sean Anderson wrote:
smp_call_function_single disables IRQs when executing the callback. To prevent deadlocks, we must disable IRQs when taking cgr_lock elsewhere. This is already done by qman_update_cgr and qman_delete_cgr; fix the other lockers.
Fixes: 96f413f47677 ("soc/fsl/qbman: fix issue in qman_delete_cgr_safe()") CC: stable@vger.kernel.org Signed-off-by: Sean Anderson sean.anderson@seco.com Reviewed-by: Camelia Groza camelia.groza@nxp.com Tested-by: Vladimir Oltean vladimir.oltean@nxp.com
I got no response the first time I sent this, so I am resending to net. This issue was introduced in a series which went through net, so I hope it makes sense to take it via net.
[1] https://lore.kernel.org/linux-arm-kernel/20240108161904.2865093-1-sean.ander...
(no changes since v3)
Changes in v3:
- Change blamed commit to something more appropriate
Changes in v2:
- Fix one additional call to spin_unlock
Leo Li (Li Yang) is no longer with NXP. Until we figure out within NXP how to continue with the maintainership of drivers/soc/fsl/, yes, please continue to submit this series to 'net'. I would also like to point out to Arnd that this is the case.
Arnd, a large portion of drivers/soc/fsl/ is networking-related (dpio, qbman). Would it make sense to transfer the maintainership of these under the respective networking drivers, to simplify the procedures?
Also, your patches are whitespace-damaged. They do not apply to the kernel, and patchwork shows this as well. https://patchwork.kernel.org/project/netdevbpf/patch/20240215162327.3663092-...
Please repost with this fixed.