Re: [PATCH v4 2/3] x86/sgx: Resolve EAUG race where losing thread returns SIGBUS

On Mon Aug 12, 2024 at 11:21 AM EEST, Dmitrii Kuvaiskii wrote:

On Wed, Jul 17, 2024 at 01:38:37PM +0300, Jarkko Sakkinen wrote:

...

Fixes should be in the head of the series so please reorder.

Do you mean that the preparation patch [1] should be applied after the two bug fixes? This seems to not make sense -- isn't it more correct to first refactor code, and then to fix in a cleaner way? I thought that was the point of previous Dave Hansen's comments [2].

[1] https://lore.kernel.org/all/20240705074524.443713-2-dmitrii.kuvaiskii@intel.... [2] https://lore.kernel.org/all/1d405428-3847-4862-b146-dd57711c881e@intel.com/

-- Dmitrii Kuvaiskii

OK, I read the references you put, and agree with you here. Thanks for the remarks.

BR, Jarkko