On Wed, Dec 09, 2020 at 11:26:40AM +0100, Samuel Thibault wrote:
[backport of 5.10 commit f0992098cadb4c9c6a00703b66cafe604e178fea]
Speakup exposing a line discipline allows userland to try to use it, while it is deemed to be useless, and thus uselessly exposes potential bugs. One of them is simply that in such a case if the line sends data, spk_ttyio_receive_buf2 is called and crashes since spk_ttyio_synth is NULL.
This change restricts the use of the speakup line discipline to speakup drivers, thus avoiding such kind of issues altogether.
Cc: stable@vger.kernel.org Reported-by: Shisong Qin qinshisong1205@gmail.com Signed-off-by: Samuel Thibault samuel.thibault@ens-lyon.org Tested-by: Shisong Qin qinshisong1205@gmail.com Link: https://lore.kernel.org/r/20201129193523.hm3f6n5xrn6fiyyc@function Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
This, and the 4.14.y backport, fail to apply:
patching file drivers/staging/speakup/spk_ttyio.c Hunk #1 FAILED at 47. Hunk #2 succeeded at 187 (offset -4 lines). 1 out of 2 hunks FAILED -- rejects in file drivers/staging/speakup/spk_ttyio.c
What tree(s) did you make the patch against?
thanks,
greg k-h