Re: [PATCH v2] ata: libata-core: Do not call ata_dev_power_set_standby() twice

On Mon, Feb 19, 2024 at 04:44:30PM +0100, Niklas Cassel wrote:

From: Damien Le Moal dlemoal@kernel.org

For regular system shutdown, ata_dev_power_set_standby() will be executed twice: once the scsi device is removed and another when ata_pci_shutdown_one() executes and EH completes unloading the devices.

Make the second call to ata_dev_power_set_standby() do nothing by using ata_dev_power_is_active() and return if the device is already in standby.

Fixes: 2da4c5e24e86 ("ata: libata-core: Improve ata_dev_power_set_active()") Cc: stable@vger.kernel.org Signed-off-by: Damien Le Moal dlemoal@kernel.org Signed-off-by: Niklas Cassel cassel@kernel.org

---

Applied: https://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git/log/?h=for-...