Hi, Thomas,
On Tue, Apr 6, 2021 at 9:18 PM Thomas Bogendoerfer tsbogend@alpha.franken.de wrote:
On Tue, Apr 06, 2021 at 07:24:03PM +0800, Huacai Chen wrote:
Only 32bit kernel need __div64_32(), but commit c21004cd5b4cb7d479514d4 ("MIPS: Rewrite <asm/div64.h> to work with gcc 4.4.0.") makes it depend on 64bit kernel by mistake. This patch fix this longstanding error.
Fixes: c21004cd5b4cb7d479514d4 ("MIPS: Rewrite <asm/div64.h> to work with gcc 4.4.0.") Cc: stable@vger.kernel.org Signed-off-by: Huacai Chen chenhuacai@loongson.cn
arch/mips/include/asm/div64.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/include/asm/div64.h b/arch/mips/include/asm/div64.h index dc5ea5736440..d199fe36eb46 100644 --- a/arch/mips/include/asm/div64.h +++ b/arch/mips/include/asm/div64.h @@ -11,7 +11,7 @@
#include <asm-generic/div64.h>
-#if BITS_PER_LONG == 64 +#if BITS_PER_LONG == 32
are you sure this will make a difference ? asm-generic/div64.h checks for __div64_32, which is not defined before including it here.
Sorry for my carelessness, the #include should be after __div64_32, and there are other bugs in this file, I will send a new version.
Huacai
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]