On Mon, Dec 19, 2022 at 3:23 PM Luis Chamberlain mcgrof@kernel.org wrote:
On Mon, Dec 19, 2022 at 02:46:09PM -0600, Allen Webb wrote:
A one character difference in the name supplied to MODULE_DEVICE_TABLE breaks a future patch set, so fix the typo.
What behaviour is broken here for older kernels? What would not work that makes this patch worthy of consideration for stable? The commit log should be clear on that.
In the future, it may be useful for you to wait at least 1 week or so before sending a new series becuase just a couple of days is not enough if you are getting feedback.
So before sending a v10, please give it at least a few days or a week.
Luis
On Tue, Dec 20, 2022 at 12:42 AM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Mon, Dec 19, 2022 at 02:46:09PM -0600, Allen Webb wrote:
A one character difference in the name supplied to MODULE_DEVICE_TABLE breaks a future patch set, so fix the typo.
Breaking a future change is not worth a stable backport, right? Doesn't this fix a real issue now? If so, please explain that.
thanks,
greg k-h
I will update the commit message to say that it breaks compilation when building imx8mp-blk-ctrl as a module (and so forth for the other similar patches).