Hi Dietmar,
I love your patch! Perhaps something to improve:
[auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on v5.17-rc8 next-20220310] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Dietmar-Eggemann/arch_topology-Swap... base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 4a248f85b3dd8e010ff8335755c927130e9b0764 config: arm-defconfig (https://download.01.org/0day-ci/archive/20220315/202203150553.QRvgHFHm-lkp@i...) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/7528fb2ea1e30038ee1dcc48df9d41350297... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dietmar-Eggemann/arch_topology-Swap-MC-CLS-SD-mask-if-MC-weight-1/20220315-004742 git checkout 7528fb2ea1e30038ee1dcc48df9d413502977895 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/base/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/base/arch_topology.c:617:23: warning: no previous prototype for '_cpu_coregroup_mask' [-Wmissing-prototypes]
617 | const struct cpumask *_cpu_coregroup_mask(int cpu) | ^~~~~~~~~~~~~~~~~~~
drivers/base/arch_topology.c:634:23: warning: no previous prototype for '_cpu_clustergroup_mask' [-Wmissing-prototypes]
634 | const struct cpumask *_cpu_clustergroup_mask(int cpu) | ^~~~~~~~~~~~~~~~~~~~~~
vim +/_cpu_coregroup_mask +617 drivers/base/arch_topology.c
616
617 const struct cpumask *_cpu_coregroup_mask(int cpu)
618 { 619 const cpumask_t *core_mask = cpumask_of_node(cpu_to_node(cpu)); 620 621 /* Find the smaller of NUMA, core or LLC siblings */ 622 if (cpumask_subset(&cpu_topology[cpu].core_sibling, core_mask)) { 623 /* not numa in package, lets use the package siblings */ 624 core_mask = &cpu_topology[cpu].core_sibling; 625 } 626 if (cpu_topology[cpu].llc_id != -1) { 627 if (cpumask_subset(&cpu_topology[cpu].llc_sibling, core_mask)) 628 core_mask = &cpu_topology[cpu].llc_sibling; 629 } 630 631 return core_mask; 632 } 633
634 const struct cpumask *_cpu_clustergroup_mask(int cpu)
635 { 636 return &cpu_topology[cpu].cluster_sibling; 637 } 638
--- 0-DAY CI Kernel Test Service https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org