Hi Dirk-san,
From: Dirk Behme, Sent: Friday, April 12, 2019 2:29 PM
Having a cyclic DMA, a residue 0 is not an indication of a completed DMA. In case of cyclic DMA make sure that dma_set_residue() is called and with this a residue of 0 is forwarded correctly to the caller.
Fixes: 3544d2878817 ("dmaengine: rcar-dmac: use result of updated get_residue in tx_status") Signed-off-by: Dirk Behme dirk.behme@de.bosch.com Signed-off-by: Achim Dahlhoff Achim.Dahlhoff@de.bosch.com Signed-off-by: Hiroyuki Yokoyama hiroyuki.yokoyama.vx@renesas.com Signed-off-by: Yao Lihua ylhuajnu@outlook.com Cc: stable@vger.kernel.org # v4.8+
Thank you for the patch! Since cyclic transfers will not stop even if the residue is 0, I agree this driver should not return DMA_COMPLETE (transaction completed). So,
Reviewed-by: Yoshihiro Shimoda yoshihiro.shimoda.uh@renesas.com
Best regards, Yoshihiro Shimoda