On 6/14/24 17:36, João Paulo Gonçalves wrote:
From: João Paulo Gonçalves joao.goncalves@toradex.com
The condition for checking if triggers belong to the same IIO device to set attached_own_device is currently inverted, causing iio_trigger_using_own() to return an incorrect value. Fix it by testing for the correct return value of iio_validate_own_trigger().
Cc: stable@vger.kernel.org Fixes: 517985ebc531 ("iio: trigger: Add simple trigger_validation helper") Signed-off-by: João Paulo Gonçalves joao.goncalves@toradex.com
Reviewed-by: Matti Vaittinen mazziesaccount@gmail.com
Thanks for fixing this!
drivers/iio/industrialio-trigger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c index 16de57846bd9..2e84776f4fbd 100644 --- a/drivers/iio/industrialio-trigger.c +++ b/drivers/iio/industrialio-trigger.c @@ -315,7 +315,7 @@ int iio_trigger_attach_poll_func(struct iio_trigger *trig, * this is the case if the IIO device and the trigger device share the * same parent device. */
- if (iio_validate_own_trigger(pf->indio_dev, trig))
if (!iio_validate_own_trigger(pf->indio_dev, trig)) trig->attached_own_device = true;
return ret;
-- 2.34.1