On Sun, Dec 24, 2023 at 3:00 PM Paul Moore paul@paul-moore.com wrote:
On Sat, Dec 23, 2023 at 10:34 AM Eric Biggers ebiggers@kernel.org wrote:
On Fri, Dec 22, 2023 at 08:23:26PM -0500, Paul Moore wrote:
Is it considered valid for a native 64-bit task to use 32-bit FS_IO32_XXX flags?
No, that's not valid.
Excellent, thank you.
If not, do we want to remove the FS_IO32_XXX flag checks in selinux_file_ioctl()?
I don't see any such flag checks in selinux_file_ioctl().
Neither do I ... I'm not sure what I was looking at when I made that comment, I'm going to chalk that up to a bit of holiday fog. Sorry for the noise.
Ah ha, I think I found the problem - the tools I use to pull in patches for review seemed to have grabbed an old version of the patch that *did* as the 32-bit ioctl commands to selinux_file_ioctl().
https://lore.kernel.org/selinux/20230906102557.3432236-1-alpic@google.com/