Re: [PATCH 1/3] net: bcmgenet: synchronize EXT_RGMII_OOB_CTRL access

On Thu, Apr 25, 2024 at 03:10:05PM -0700, Doug Berger wrote:

The EXT_RGMII_OOB_CTRL register can be written from different contexts. It is predominantly written from the adjust_link handler which is synchronized by the phydev->lock, but can also be written from a different context when configuring the mii in bcmgenet_mii_config().

The chances of contention are quite low, but it is conceivable that adjust_link could occur during resume when WoL is enabled so use the phydev->lock synchronizer in bcmgenet_mii_config() to be sure.

Fixes: afe3f907d20f ("net: bcmgenet: power on MII block for all MII modes") Cc: stable@vger.kernel.org Signed-off-by: Doug Berger opendmb@gmail.com

Reviewed-by: Simon Horman horms@kernel.org