Re: [PATCH v2] ext4: fix off by one issue in alloc_flex_gd()

On 9/27/24 8:33 AM, libaokun@huaweicloud.com wrote:

From: Baokun Li libaokun1@huawei.com

...

Delete the problematic plus 1 to fix the issue, and add a WARN_ON_ONCE() to prevent the issue from happening again.

Reported-by: Wesley Hershberger wesley.hershberger@canonical.com Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2081231 Reported-by: Stéphane Graber stgraber@stgraber.org Closes: https://lore.kernel.org/all/20240925143325.518508-1-aleksandr.mikhalitsyn@ca... Tested-by: Alexander Mikhalitsyn aleksandr.mikhalitsyn@canonical.com Tested-by: Eric Sandeen sandeen@redhat.com

The patch has changed a little since I tested, but it still passes my testcase (as expected, no WARN ON etc) so looks good from that POV, thanks! -Eric