On 25/07/22 13:41, Jason A. Donenfeld wrote:
Hi Valentin,
On Mon, Jul 25, 2022 at 12:09 PM Valentin Schneider vschneid@redhat.com wrote:
maybe at some point I'll look into overhauling all of this so that none of this will be required anyway. So I think v10 is my final submission on this.
I think that's fair, I hope I didn't discourage you too much from contributing in that area.
While not strictly necessary because of Eric's ack, since you continue to grow this thread that addresses an active bug people are suffering from, it might be some very useful signaling if you too would provide your Acked-by, so that Kalle picks this up and people's laptops work again.
I don't think the __set_notify_signal() approach is functionally wrong, but I also believe it isn't the proper tool for the job (for reasons I wrote previously).
I won't ack it, but I won't nack it either if others find it satisfactory.