Re: [PATCH v2] leds: flash: leds-qcom-flash: Fix registry access after re-bind

On 5/29/2025 2:33 PM, Krzysztof Kozlowski wrote:

Driver in probe() updates each of 'reg_field' with 'reg_base':

for (i = 0; i < REG_MAX_COUNT; i++) regs[i].reg += reg_base;

'reg_field' array (under variable 'regs' above) is statically allocated, thus each re-bind would add another 'reg_base' leading to bogus register addresses. Constify the local 'reg_field' array and duplicate it in probe to solve this.

Fixes: 96a2e242a5dc ("leds: flash: Add driver to support flash LED module in QCOM PMICs") Cc: stable@vger.kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org

---

Reviewed-by: Fenglin Wu fenglin.wu@oss.qualcomm.com